Github user stain commented on the issue:
https://github.com/apache/incubator-taverna-common-activities/pull/3
Hi, I'm OK with incremental pull requests, but the problem is that if you
have multiple open pull requests from the same branch, then they are
effectively the same pull requests and I wouldn't know which commit to review..
When you have a sizeable code, as in #8, then open a new pull request from
a new "feature" branch on your GitHub repository. If we need to fix some small
details for that pull requests, then you can fix it on that branch separately.
We can then review this and merge it - while you keep working on something else.
For your continued work, you can then do that on a new feature branch, so
you don't affect the pull request and we can review it without having a moving
target. You might need to occasionally merge your older feature branches into
the newer feature branches.
Obviously here you are not doing independent patches, you are building on
your own work, and so you would base such new feature branches from your own
feature branch, rather than the Apache branch (which might lag behind).
This is an area where GitHub pull requests start being difficult, because
your newer pull request will build on the old one, so you can just say "Depends
on #3") so they can be reviewed in order. But even if we do merge the later PR,
then GitHub will figure out both PRs have been merged.
Your feature branches shouldn't be called "branch_1" etc, but rather refer
either to a JIRA issue number or to the main fixed/new feature, e.g.
`dockerjava` or `certificate-path`.
GitHub will tell you "You can safely delete this branch" once a pull
request is accepted, just click the "Delete" branch there, and do `git branch
-d` locally after pulling the new upstream.
No, I would not prefer a "One PR at the end of GSOC" approach :) Let's
continue with small PRs so they are easy to review :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
