On 27 June 2016 at 18:26, Thilina Manamgoda <[email protected]> wrote:
> Hi,
>
> "Fix the logging and early return, then it should be ready for a pull
> request" . I get the logging part what you meant by "early return".

Here:

https://github.com/ThilinaManamgoda/incubator-taverna-common-activities/blob/workbench/taverna-cwl-activity-ui/src/main/java/org/apache/taverna/cwl/ui/serviceprovider/CwlServiceProvider.java#L62

you can't just print the stacktrace, you also need to return,
otherwise the variable stream will be null, and the line below doing
stream.spliterator() will crash.



> I have added the resource folder and modified class names. But still i get
> the error ? :
> https://github.com/ThilinaManamgoda/incubator-taverna-common-activities/tree/workbench/taverna-cwl-activity-ui/src/resources


Try to remove the this  taverna-activity-test-utils dependency:

https://github.com/ThilinaManamgoda/incubator-taverna-common-activities/blob/workbench/taverna-cwl-activity-ui/pom.xml#L48


-- 
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718

Reply via email to