Github user alaninmcr commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-common-activities/pull/14#discussion_r70789844
--- Diff:
taverna-docker-activity/src/test/java/org/apache/taverna/activities/docker/test/TestDockerCommands.java
---
@@ -40,7 +40,7 @@
private static final String DOCKER_LOGIN_SUCCESS = "Login Succeeded";
- public TestDockerCommands(){
+ public TestDockerCommands() {
DockerContainerConfigurationImpl containerConfiguration = new
DockerContainerConfigurationImpl(new TestConfigurationManager());
containerConfiguration.getInternalPropertyMap().put(DockerContainerConfigurationImpl.NAME,CONTAINER_NAME);
--- End diff --
containerConfiguration should be a DockerContainerConfiguration. Any code
specific to the implementation should not be visible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
