On 14-Jul-16 03:12, Nadeesh Dilanga wrote:
Hi Alan, Hi Stian,

Hello

I have sent out a latest pull request which has a README on how to run the
unit tests and also added the feedback given by Stian.

Please let me know if anything else needs to be fixed.

The main issue I see is that you are using methods in DockerContainerConfigurationImpl. In my opinion anything that you need should be visible in DockerContainerConfiguration and accessed from that.

Alan

Reply via email to