Hello, There are some 'test' files in workbench that rat complains about:
incubator-taverna-workbench/taverna-renderers-impl/src/test/resources/test.svg incubator-taverna-workbench/taverna-renderers-impl/src/test/resources/test.html incubator-taverna-workbench/taverna-renderers-impl/src/test/resources/test.xml incubator-taverna-workbench/taverna-renderers-impl/src/test/resources/test.txt incubator-taverna-workbench/taverna-renderers-impl/src/test/resources/test.csv These may or may not need headers according to https://www.apache.org/legal/src-headers.html#faq-exceptions. You probably can't have comments in csv anyway. We may have to add an excludes file to each project http://creadur.apache.org/rat/apache-rat-plugin/check-mojo.html#excludesFile Cheers, Ian On 30/11/16 10:11, Ian Dunlop wrote: > Hello, > > There are lots of files in > incubator-taverna-workbench-common-activities-ian/taverna-localworker-activity-ui/src/main/resources/ > which do not have apache headers. Some of these look like t2flows and > others are JSON. The ones which look like t2flows do not have a file > extension. Is it safe to put the header in them? Will it break something > later. As far as I know you can't put a comment in a JSON file so what > is the best way to handle this? Do they need the apache headers at all? > Is a licence file which lists all these files the way to approach it. Or > is this the thing that a NOTICE file would cover? > > Cheers, > Ian > > On 30/11/16 09:49, Ian Dunlop wrote: >> Hello, >> >> I've put a couple of pull requests in for taverna server xsd headers and >> workbench-common-activities pom headers. It's worth a quick scan by >> someone to check they look ok. >> >> Cheers, >> >> Ian >> >> >> On 28/11/16 15:16, Sagar wrote: >>> Hello, >>> >>> Congratulations @stain for promotion. >>> >>> On Mon 28 Nov, 2016 7:29 pm Ian Dunlop, <[email protected]> wrote: >>> >>>> Hello, >>>> >>>> Congrats on the Incubator promotion Stian. Sounds like a good idea if >>>> you become a Taverna mentor. Now, I've got this idea for a project I'd >>>> like to pitch to you.......;) >>>> >>>> Cheers, >>>> >>>> Ian >>>> >>>> >>>> On 23/11/16 22:25, Gale Naylor wrote: >>>>> Congratulations, Stian! Even though we appear to be close to graduation, >>>> is >>>>> there any reason, *not* to add yourself as a mentor? You can add it to >>>> your >>>>> resume. ;) >>>>> >>>>> On Wed, Nov 23, 2016, 6:42 AM Stian Soiland-Reyes <[email protected]> >>>> wrote: >>>>> On 23 November 2016 at 14:10, Andy Seaborne <[email protected]> wrote: >>>>>> PS Stian - I don't see why you can't add your self as a mentor. >>>>> No need for that if we graduate? :-) >>>>> >>>>> >>>>> Folks - Andy is referring to the fact I was just voted to be a member >>>>> of the Incubator PMC. So technically I could now be a mentor for >>>>> Taverna (and i guess Andy relax slightly). >>>>> >>>>> Should I add myself as mentor? >>>>> >>>>> >>>>> BTW, I see we also need to update >>>>> http://incubator.apache.org/projects/taverna.html to list the new >>>>> committers. >>>>> >>>>> -- >>>>> Stian Soiland-Reyes >>>>> http://orcid.org/0000-0001-9842-9718 >>>>> >
signature.asc
Description: OpenPGP digital signature
