Github user sagar15795 commented on a diff in the pull request:
https://github.com/apache/incubator-taverna-mobile/pull/64#discussion_r171596749
--- Diff: app/src/main/res/layout/fragment_login.xml ---
@@ -42,42 +44,43 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_below="@+id/logo"
+ android:typeface="serif"
android:layout_centerHorizontal="true"
- android:layout_marginTop="42dp"
+ android:layout_marginTop="@dimen/textMargin_appName"
android:text="@string/app_name"
- android:textSize="25sp"/>
+ android:textSize="@dimen/text_size" />
<LinearLayout
android:id="@+id/loginlayout"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_below="@+id/tvAppName"
android:layout_centerInParent="true"
- android:layout_marginTop="20dp"
- android:background="@android:color/white"
+ android:layout_marginTop="@dimen/layout_login"
android:orientation="vertical"
- android:padding="20dp">
+ android:padding="@dimen/layout_login">
<TextView
android:id="@+id/tvLoginInfo"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:background="#E1E1E1"
--- End diff --
Move it to `color.xml`
---
