m4sterchain commented on a change in pull request #198: Refactor remote
attestation code
URL: https://github.com/apache/incubator-teaclave/pull/198#discussion_r361898910
##########
File path: teaclave_attestation/src/key.rs
##########
@@ -0,0 +1,167 @@
+use anyhow::Result;
+use sgx_tcrypto::SgxEccHandle;
+use sgx_types::{sgx_ec256_private_t, sgx_ec256_public_t};
+use std::prelude::v1::*;
+
+pub const CERT_VALID_DAYS: i64 = 90i64;
+
+pub struct Secp256k1KeyPair {
+ pub prv_k: sgx_ec256_private_t,
Review comment:
It seems that the prv_k field is not directly used by other modules, is it
OK to remove the pub modifier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
