+1. All tests passed. (I spotted a few places in the doc that can be improved, but nothing critical.)
Best, Pei On Thu, Oct 1, 2020 at 6:28 AM Furkan KAMACI <[email protected]> wrote: > Hi, > > +1 from me. > > I checked: > > - Incubating in name > - DISCLAIMER-WIP exists > - LICENSE and NOTICE are fine > - No unexpected binary files > - Checked PGP signatures > - Checked checksums > - Code compiles and tests successfully run > > Kind Regards, > Furkan KAMACI > > On Thu, Oct 1, 2020 at 8:18 AM Yu Ding <[email protected]> wrote: > > > +1 > > > > All tests passed. > > > > Best, > > Yu > > > > On Wed, Sep 30, 2020 at 10:16 PM Tongxin Li <[email protected]> > > wrote: > > > > > +1 > > > > > > For both SGX and simulation mode, I successfully compiled from the > source > > > tarball, launched the services and ran the built-in echo example. > > > > > > Best, > > > Tongxin Li > > > > > > On Tue, Sep 29, 2020 at 5:33 PM Mingshen Sun <[email protected]> wrote: > > > > > > > Dear Teaclave community, > > > > > > > > I am pleased to be calling this vote for the first release of Apache > > > > Teaclave (incubating) 0.1.0 (release candidate 2). The building issue > > has > > > > been fixed compared to the rc.1. > > > > > > > > The release candidate to be voted over is available at: > > > > - > > > https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.1.0-rc.2/ > > > > > > > > The release candidate is signed with a GPG key available at: > > > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS > > > > > > > > The Git commit for this release is: > > > > - > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=incubator-teaclave.git;a=commit;h=05769c80fd15612003d629603cadd2ecddbfca46 > > > > > > > > The Release Note is available in: > > > > - > > > https://github.com/apache/incubator-teaclave/releases/tag/v0.1.0-rc.2 > > > > > > > > Build guide and get started instructions can be found at: > > > > - > > > > > > > > > > > > > > https://github.com/apache/incubator-teaclave/blob/v0.1.0-rc.2/docs/my-first-function.md > > > > > > > > The short version of building Teaclave from the source tarball: > > > > > > > > ``` > > > > $ wget > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.1.0-rc.2/apache-teaclave-0.1.0-rc.2-incubating.tar.gz > > > > $ tar zxvf apache-teaclave-0.1.0-rc.2-incubating.tar.gz && > > > > cd apache-teaclave-0.1.0-rc.2-incubating > > > > > > > > $ docker run --rm -v $(pwd):/teaclave -w /teaclave \ > > > > > > > > -it teaclave/teaclave-build-ubuntu-1804-sgx-2.9.1:latest \ > > > > > > > > bash -c ". /root/.cargo/env && \ > > > > > > > > . /opt/sgxsdk/environment && \ > > > > > > > > mkdir -p build && cd build && \ > > > > > > > > cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. > && \ > > > > > > > > make" > > > > > > > > ``` > > > > > > > > The vote will be open for at least 72 hours. Everyone is welcomed to > > > vote. > > > > Please vote by replying to this thread explicitly. > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > Anyone can participate in testing and voting, not just committers, > > please > > > > feel free to try out the release candidate and provide your votes. > > > > > > > > A checklist for reference: > > > > - > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > Since this voting is the first release for the Teaclave community, > I'd > > > like > > > > to mention that you can also reply with things you have checked. > > > > > > > > Best, > > > > Mingshen Sun > > > > > > > > > >
