I found that you introduce some headers, what's the purpose? They are in LGPL license which are not accepted [1] by the Apache projects.
[1] https://www.apache.org/legal/resolved.html I don't think this can be included in Teaclave SGX SDK as samples. - The purpose of samples in Teaclave SGX SDK is to demonstrate the usages of SDK or the benefits of using Rust. However, most of the code are written in C. I'm not convinced to include this in the samples. - The license issue should be addressed. As I said, I found some LGPL headers which are not accepted. Also, you mentioned that this sqlite implementation is from another project, we also need to make sure the license are accepted. - This PR introduce a lot of code which are hard to audit/review. Also, most of code are not related with the SDK itself. Although this is sample code, we still need to ensure the security in case other people grab it without auditing it. IIRC, there was a peer-reviewed paper include a bug in our sample code as their findings. Overall, I hope you can understand my concerns. BTW, it's totally okay to provide it as a separate project instead of merging into this repo. You can create a new repo by yourself and open source it. Or, we have an organization called Secure Computing Community (https://github.com/sccommunity), which hosts related (experimental) projects and third-party libraries around Teaclave. I think that's a good place to put your contribution. Feel free to comment if you have different ideas. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/274#issuecomment-714923055
