+1 Signatures good, builds and tests good (using Docker), proper disclaimer files, license, notice, and license header info in rust source files (though not all of them; those will need license clarification later).
Notes for future releases (not blocking due to DISCLAIMER-WIP): there are some source files that support comments like .toml, Dockerfile, .yml, .sh, and so forth, that will need appropriate Apache License headers. This is detailed at [1]. See [2] for a short form that would be useful for certain files that have limited space for license info. [1]: https://www.apache.org/legal/src-headers.html [2]: https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available On Fri, 4 Jun 2021 at 18:02, Rundong Zhou <rundongz...@apache.org> wrote: > > +1 > > Regards, > Rundong > > On 2021/06/04 22:18:59, Mingshen Sun <ms...@apache.org> wrote: > > Dear Teaclave community, > > > > I am pleased to be calling this vote for the first release of Apache > > Teaclave TrustZone SDK (incubating) 0.1.0 (release candidate 1). > > > > The release candidate to be voted over is available at: > > - > > https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.1.0-rc.1 > > > > The release candidate is signed with a GPG key available at: > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS > > > > The Git commit for this release is: > > - > > https://gitbox.apache.org/repos/asf?p=incubator-teaclave-trustzone-sdk.git;a=commit;h=8587ffca8d3dbed15d2a36ed7cd6a33b6efd8965 > > > > The release note is available in: > > - > > https://github.com/apache/incubator-teaclave-trustzone-sdk/releases/tag/v0.1.0-rc.1 > > > > Build guide and get started instructions can be found at: > > - > > https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/v0.1.0-rc.1/README.md > > > > The short version of building and testing Teaclave TrustZone SDK from > > the source tarball: > > > > ``` > > $ wget > > https://dist.apache.org/repos/dist/dev/incubator/teaclave/trustzone-sdk-0.1.0-rc.1/apache-teaclave-trustzone-sdk-0.1.0-rc.1-incubating.tar.gz > > $ tar zxvf apache-teaclave-trustzone-sdk-0.1.0-rc.1-incubating.tar.gz && cd > > apache-teaclave-trustzone-sdk-0.1.0-incubating > > > > $ # Instructions to verify the source tar: > > https://teaclave.apache.org/download/#verify-the-integrity-of-the-files > > > > $ # Building > > $ docker run --rm -it -v$(pwd):/teaclave-trustzone-sdk -w > > /teaclave-trustzone-sdk teaclave/teaclave-trustzone-sdk-build:0.1.1 > > bash -c "source environment && make" > > > > $ # Testing > > $ docker run --rm -it -v$(pwd):/teaclave-trustzone-sdk -w > > /teaclave-trustzone-sdk teaclave/teaclave-trustzone-sdk-build:0.1.1 > > bash -c "source environment && cd ci && ./ci.sh" > > ``` > > > > The vote will be open for at least 72 hours. Everyone is welcome to > > vote. Please vote by replying to this thread explicitly. > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Anyone can participate in testing and voting, not just committers, > > please feel free to try out the release candidate and provide your > > votes. > > > > A checklist for reference: > > - > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > Note that you can also reply with things you have checked. > > > > Best, > > > > Mingshen Sun > > http://mssun.me > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org > > For additional commands, e-mail: dev-h...@teaclave.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org > For additional commands, e-mail: dev-h...@teaclave.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
