Hi @henrysun007, thanks for the PR.

The reason we choose to put in the `common` directory is that we have changed 
`rusty_leveldb` a lot, and we don't have any plan to upstream the changes. 
Therefore, we'd like to keep it in the Teaclave codebase as a part of Teaclave.

I saw you're using a submodule for the changes (which is not under the Apache 
organization). This may be not suitable for further maintenance. Can you PR the 
changes of the `rusty_leveldb_sgx` in the source code?

For the name of the `common` directory, if you have better suggestion. Please 
advise.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/661#issuecomment-1291404332
You are receiving this because you are subscribed to this thread.

Message ID: <apache/incubator-teaclave/pull/661/c1291404...@github.com>

Reply via email to