DemesneGH commented on PR #110: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/110#issuecomment-1519053286
Thanks for your proposal. I appreciate the commits https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/110/commits/5d0e7d62e9f0f8f56d4807d557d61356f1e319ee and https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/110/commits/56210a5e24326ce2fd65f862ed2b258a4db7cf0c, and they seem good to go. Regarding the ["create overarching Cargo workspace"](https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/110/commits/0bb8b9c1c553a76a7a31c821fc0d7881c5c2bbe4) commit: > If we did add the examples to the workspace, we could build all of them much faster since they'd share a dependency graph. I agree with you. The `host` and `ta` both share the `proto` crate, and they are built with different toolchains. While this organization allows for building individual examples separately, it does indeed require more time to build all examples. I think adding a Cargo workspace for `optee-teec` alone would not have a significant impact unless we include the `examples` in the workspace. However, since the host and TA rely on different toolchains, and Cargo does not support two workspaces in one root folder, we would need to reorganize the examples to separate the `host` and `ta`. Considering the shared `proto` crate, this approach would likely complicate the examples' structure. So I would suggest merging the first two commits and revisiting the last commit at a later time if necessary. Any ideas about the ways of workspace organization would be appreciated. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
