jforissier commented on PR #114:
URL: 
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/114#issuecomment-1875077034

   > > Perhaps just make it ?= y by default, but it is always good to have a 
way to disable things in case they break.
   > 
   > That sounds reasonable. I will do that as a next step to current rust 
examples build refactoring.
   
   OK thanks.
    
   > > This also raises the question of make check (C apps) vs make check-rust. 
Should make check run both? (it makes sense if make builds both). But then we 
may want to be able to run only the C apps perhaps (make check-c?). TBD.
   > 
   > How about if we rather add `rust.exp` to build repo and have the check 
tests conditional under `CHECK_TESTS` similar to what we did for trusted keys 
tests?
   
   Yes, much better :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org

Reply via email to