ivila commented on PR #198: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/198#issuecomment-2948736936
> According to #181, "rebuild the prebuilt QEMU images accordingly (the image should be given a new name to avoid affecting existing works)" @ivila could you give some short guidance on what should I do? Thanks! > > I see we can rebuild the OP-TEE images here: https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/main/.github/workflows/reuse_build_test_qemu_image.yml#L68 but seems not pinned to a fixed OP-TEE version? Currently, no immediate action is required. I suggest we wait for OP-TEE to release a new version of `OP-TEE/optee_os` (v4.7.0), as the current version (v4.6.0) does **not** include [this commit for the default key update](https://github.com/OP-TEE/optee_os/commit/5d5d7d0b1c038a6836be9f0b38585f5aa6a4dd01). However, if we want to stay aligned with the latest master branch of OP-TEE, we need to make the following updates: ---- ## 1. Update the Build Test QEMU Image Workflow We should revise the naming strategy used in the file: [.github/workflows/reuse_build_test_qemu_image.yml](https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/7cc93e6f4d3fa249af0825228424bc9e452528e2/.github/workflows/reuse_build_test_qemu_image.yml#L58) Currently, the images are named: * `${arch}-optee-qemuv8-ubuntu-24.04` * `${arch}-optee-qemuv8-ubuntu-24.04-expand-ta-memory` To improve clarity and avoid CI mismatches for contributors who fork the repository with older OP-TEE versions(older version of incubator-teaclave-trustzone-sdk) , we should include the OP-TEE version in the image name. The updated strategy would look like: * `${arch}-optee-${optee_tag}-qemuv8-ubuntu-24.04` * `${arch}-optee-${optee_tag}-qemuv8-ubuntu-24.04-expand-ta-memory` After updating the naming strategy: 1. Go to Actions > Build Test Qemu Image. 2. Click Run workflow and select the correct branch that contains your updates.  3. After the workflow completes successfully, download the generated artifacts (see [example run](https://github.com/ivila/incubator-teaclave-trustzone-sdk/actions/runs/14661579831)). 4. Upload the artifacts to: https://nightlies.apache.org/teaclave/teaclave-trustzone-sdk/ Upload the artifacts to: https://nightlies.apache.org/teaclave/teaclave-trustzone-sdk/ ---- ## 2. Update OP-TEE Version in Setup Scripts In the file: https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/63791367dc150194609e958fc40da601e595456d/build_optee_libraries.sh#L22 Change the `OPTEE_VERSION=4.5.0` to `OPTEE_VERSION=${new version}` In the file: https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/7cc93e6f4d3fa249af0825228424bc9e452528e2/tests/setup.sh#L26 Update the line `IMG_VERSION="$(uname -m)-optee-qemuv8-ubuntu-24.04"` to use the same naming strategy as step1 do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
