DemesneGH commented on code in PR #206: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/206#discussion_r2191848713
########## scripts/runtime/environment: ########## @@ -15,104 +17,81 @@ # specific language governing permissions and limitations # under the License. -# This script is written into .bashrc to set up toolchains when enter the docker, like: -# docker run -it \ -# -e TA_ARCH=aarch64 \ -# -e CA_ARCH=arm \ -# -e STD=y \ -# teaclave-dev bash +# ============================================================================= +# config/environment (Main configuration - loads active configs) +# ============================================================================= + +# Exit on any error +set -euo pipefail Review Comment: The `-e` causes docker container shell exit on any error. e.g. ``` ~/teaclave_sdk_src# switch_config Error: No option specified [The docker container stopped] ``` And other errors such as "vim command not found" also causes container shell exit. Recommend remove the '-e'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
