Copilot commented on code in PR #209:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/209#discussion_r2204909758
##########
crates/secure_db/src/db.rs:
##########
@@ -40,6 +41,8 @@ impl SecureStorageDb {
// create new db
Ok(Self {
name,
+ // TODO: use std::HashSet will result in
+ // `write permission fault` here, but I don't know why.
Review Comment:
[nitpick] This TODO is unclear about the underlying issue with
`std::collections::HashSet` and write permissions. Consider clarifying the root
cause or removing the TODO if it is no longer applicable.
```suggestion
// Note: `std::collections::HashSet` was replaced with
`hashbrown::HashSet`
// due to a write permission fault observed during
testing. The exact cause
// of the issue is unclear, but using
`hashbrown::HashSet` resolves it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
