m4sterchain commented on PR #238: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/238#issuecomment-3404109161
The current design implements: - Static license header check on PRs - Auto-fix license headers on push events However, our development workflow enforces that all code changes must: - Be submitted via PR - Pass all CI checks (including license header validation) - Be reviewed and approved before merging Given these constraints, the auto-fix step on push appears unnecessary because: - Any code reaching the main branch has already passed the license header check in the PR pipeline - If headers were missing/incorrect, the PR would have failed and required manual fixes before merge - The auto-fix would only trigger on already-compliant code, resulting in no changes Recommendation: - Remove the auto-fix step and rely solely on the PR check to enforce license compliance. This simplifies the CI pipeline and aligns with our branch protection strategy. - Alternatively, if there's a specific use case for auto-fix that I'm missing (e.g., automated bot commits, migration scenarios), please clarify so we can document when this step would actually execute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
