asir66 commented on PR #245: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/245#issuecomment-3585612877
> @asir66 Thanks for your detailed and careful testing! > > > I encountered an issue related to path resolution in `cargo-optee`. The behavior is inconsistent between `mnist-rs` and other examples such as `hello_world-rs` and `acipher-rs`. Since the root cause is not yet clear to me, I would like to ask for guidance or insights from the community. > > The `mnist-rs` have the workspace in `mnist/ta/Cargo.toml`, could you help to check if the issue related with this? > > > I would like to ask whether the project would benefit from having a Makefile under the examples/ directory to manage or build all examples together. Is this something we might need? Like [examples/Makefile](https://github.com/apache/teaclave-trustzone-sdk/blob/23a041fd658c99f542e3ba83331784fbe8453819/examples/Makefile) > > The `ci/build.sh` performs as what original Makefile does, it reads the `examples/metadata.json` to get all app path of examples and build. Please also help to check if it enough for our use case? > > For other recommendations: > > 1. I'd prefer: > Introduce explicit CLI flags: > --std > --no-std > > 3 and 4: LGTM. Please help to fix the 1. 3. 4. thanks. It’s my pleasure — I’d be glad to work on that. By the way, could you clarify whether we should use host or ca in this project? > 5. The cargo-optee tool isn’t tied to the dev Docker image, so we can keep the current dev image unchanged and consider optimizing it later. > However, if we merge this PR, our documentation and CI will need a full update. > How about we add cargo-optee in this PR while keeping both the old Makefile system and the new tool? After this merged, we can update the docs and CI step by step, and remove the Makefiles once the new tool is stable and widely used. What do you think? LGTM! I think this approach is great — it allows users to transition smoothly from the old Makefile workflow to the new tool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
