ivila commented on code in PR #260:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/260#discussion_r2601241727
##########
optee-utee/build.rs:
##########
@@ -0,0 +1,27 @@
+use std::fs;
+
+/// Outputs unstable #[feature = "foo"] iff the rustc version is older than
$version
+macro_rules! maybe_feat {
+ ($out:expr, $feat:literal, $version:literal) => {
+ {
+ let filename = $out.join(concat!($feat, ".rs"));
+
+ let s = if
version_check::is_min_version($version).unwrap_or(false) {
+ String::new()
+ } else {
+ format!("#![feature = \"{}\"]\n", $feat)
Review Comment:
Should be: `format!("#![feature({})]\n", $feat)`
##########
optee-utee/build.rs:
##########
@@ -0,0 +1,27 @@
+use std::fs;
Review Comment:
Please add a valid license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
