ivila commented on PR #268: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/268#issuecomment-3727610426
> Thanks for the PR! Introducing an option for the linking method is a good improvement and the code looks good to me. > > However, since this introduces a new implicit environment variable, could you help add some documentation in https://github.com/apache/teaclave-trustzone-sdk/blob/main/docs/advanced-setup.md? A new section like "## Linkage Method to OP-TEE C Libraries" would be good to explain how to use TEEC_STATIC to control the linking method. I’d suggest keeping this simpler by adding a feature flag, as many other crates do—for example, the [bundled feature in sqlite3-src](https://github.com/stainless-steel/sqlite3-src/blob/f92c0a8fac1b73b2de31987badc8aa227cddc11c/Cargo.toml#L23) PS: I just learned that we can use the `cfg!` macro in `build.rs` to detect enabled features. https://github.com/stainless-steel/sqlite3-src/blob/f92c0a8fac1b73b2de31987badc8aa227cddc11c/build.rs#L4-L8 <img width="863" height="261" alt="image" src="https://github.com/user-attachments/assets/96cf95b4-41e2-4a2a-ba4a-3e5c98380104"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
