ivila commented on code in PR #263:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/263#discussion_r2689158254
##########
examples/tls_server-rs/ta/Cargo.toml:
##########
@@ -45,3 +49,11 @@ optee-utee-build = { path = "../../../optee-utee-build" }
panic = "abort"
lto = false
opt-level = 3
+
+[package.metadata.optee.ta]
+arch = "aarch64"
+debug = false
+std = true
+uuid-path = "../uuid.txt"
+ta-dev-kit-dir = { aarch64 =
"/opt/teaclave/optee/optee_os/out/arm-plat-vexpress/export-ta_arm64", arm =
"/opt/teaclave/optee/optee_os/out/arm-plat-vexpress/export-ta_arm32" }
Review Comment:
Same as above.
##########
examples/tls_client-rs/ta/Cargo.toml:
##########
@@ -45,3 +49,11 @@ optee-utee-build = { path = "../../../optee-utee-build" }
panic = "abort"
lto = false
opt-level = 3
+
+[package.metadata.optee.ta]
+arch = "aarch64"
+debug = false
+std = true
+uuid-path = "../uuid.txt"
+ta-dev-kit-dir = { aarch64 =
"/opt/teaclave/optee/optee_os/out/arm-plat-vexpress/export-ta_arm64", arm =
"/opt/teaclave/optee/optee_os/out/arm-plat-vexpress/export-ta_arm32" }
Review Comment:
Do not hardcode them here, as doing so may cause failures when developers
use our tools.
You can simply add comments to it for demonstration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
