ivila commented on code in PR #285:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/285#discussion_r2917200813
##########
aarch64-unknown-optee.json:
##########
@@ -1,6 +1,6 @@
{
"arch": "aarch64",
- "data-layout": "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128",
+ "data-layout":
"e-m:e-p270:32:32-p271:32:32-p272:64:64-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128-Fn32",
Review Comment:
There are duplicate files in the cargo-optee directory. Should these be
updated as well, or would it be better to remove them entirely?
##########
examples/serde-rs/ta/Makefile:
##########
@@ -26,11 +26,6 @@ LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)gcc\"
# fix for the error: "unwinding panics are not supported without std" reported
by clippy
# Set panic=abort for std and no-std
RUSTFLAGS := -C panic=abort
-ifeq ($(BUILDER),xargo)
-EXTRA_FLAGS =
-else
-EXTRA_FLAGS = -Z build-std=core,alloc -Z
build-std-features=panic_immediate_abort
Review Comment:
`cargo-optee` adds the `build-std` flag by default; I think we should remove
that as well.
https://github.com/apache/teaclave-trustzone-sdk/blob/925a5d4b268c4e2e23255d108d111be7feb48752/cargo-optee/src/ta_builder.rs#L362-L368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
