ldshyu opened a new pull request, #303: URL: https://github.com/apache/teaclave-trustzone-sdk/pull/303
* correct quotient length in divide The comparision should be based on *magnitude* of op1 and op2, i.e., |op1| and |op2|, the code was using the `compare_big_int` if op1 is negative, incorrect length will be derived. Second, the calculation of quotient bit length is also incorrect, for example, to divide a 96 bit dividend with 64 bit divisor, The max quotient would be (2^96 - 1) / 2^63 = 2^33 - 1, which is a 33 bit value. * Implement assign function, compute_extended_gcd, abs and exp_mod * correct fn convert_to_big_int_from_fmm, this API should route to TEE_BigIntConvertFromFMM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
