Hey James, Thanks for the review. My comments are inline.
On Fri, May 6, 2016 at 6:16 PM, James Taylor <[email protected]> wrote: > Not a complete review, but some feedback: > - I'd recommend to keep going with your current versioning (with perhaps > this being an 0.8.0 release) as it's less confusing to your consumers. > That's what Phoenix did and it worked well. > Sure - will change it to 0.8.0-incubating. > - I've never seen the developers listed in the pom - that seems hard to > maintain. IMHO, I'd just remove it entirely. > Makes sense, will remove it. > - I'm not 100% positive, but if you don't have dependencies outside of the > ASF, I don't think you'll need a NOTICE file at all. > Tephra has some outside dependencies like Gson, Guava, etc. Thanks, Poorna. > > On Friday, May 6, 2016, Poorna Chandra <[email protected]> wrote: > > > Hi, > > > > I have made some changes to migrate Tephra codebase to Apache Tephra. I > > would appreciate a quick review of the changes, even though the changes > are > > mostly find-and-replace. > > > > Since we don't have github integration or JIRA yet, I am not able to send > > out pull requests or attach patches for the changes. However, the changes > > can be reviewed by looking at commit-diffs. Details are given below. > > > > There are a few things pending - > > > > 1. Update README > > - Contributing section > > - Travis build information > > - Tephra image > > 2. Update JIRA URLs in code and README once JIRA is setup > > > > > > *Things to review -* > > The branch to review - > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.git;a=log;h=refs/heads/apache-update > > > > First commit to be reviewed in the branch - > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra.git;a=commitdiff;h=818d2299ef324b17f5e09b9970ea508cf5d641c0 > > > > There are a total of six commits to be reviewed. > > > > Let me know if there is a better way this can be sent for review. > > > > Thanks, > > Poorna. > > >
