Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/14#discussion_r79964736
  
    --- Diff: 
tephra-core/src/main/java/org/apache/tephra/TransactionContext.java ---
    @@ -88,7 +88,27 @@ public boolean removeTransactionAware(TransactionAware 
txAware) {
        *     TransactionAware
        */
       public void start() throws TransactionFailureException {
    -    currentTx = txClient.startShort();
    +    txClient.startShort();
    +    staretAllTxAwares();
    +  }
    +
    +  /**
    +   * Starts a new transaction.  Calling this will initiate a new 
transaction using the {@link TransactionSystemClient},
    +   * and pass the returned transaction to {@link 
TransactionAware#startTx(Transaction)} for each registered
    +   * TransactionAware.  If an exception is encountered, the transaction 
will be aborted and a
    +   * {@code TransactionFailureException} wrapping the root cause will be 
thrown.
    +   *
    +   * @param timeout the transaction timeout for the transaction
    +   *
    +   * @throws TransactionFailureException if an exception occurs starting 
the transaction with any registered
    +   *     TransactionAware
    +   */
    +  public void start(int timeout) throws TransactionFailureException {
    +    txClient.startShort(timeout);
    --- End diff --
    
    Same here about assignment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to