[
https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590318#comment-15590318
]
ASF GitHub Bot commented on TEPHRA-194:
---------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/18#discussion_r84193226
--- Diff:
tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TBoolean.java ---
@@ -24,19 +24,29 @@
*/
package org.apache.tephra.distributed.thrift;
-import org.apache.thrift.EncodingUtils;
--- End diff --
Note that thrift does not generate imports in the order that the checkstyle
rules expect. The previous version of the generated thrift stubs was apparently
manually changed to reflect the correct order and to have a copyright. For the
copyright, I added an instruction how to add that to the README file, but for
import order, we really should not fix that manually every time we run thrift.
So we see a lot of diffs in the import section here.
> Transaction client should not retry startShort() if an invalid timeout is
> given
> --------------------------------------------------------------------------------
>
> Key: TEPHRA-194
> URL: https://issues.apache.org/jira/browse/TEPHRA-194
> Project: Tephra
> Issue Type: Bug
> Components: client
> Affects Versions: 0.9.0-incubating, 0.10.0-incubating
> Reporter: Andreas Neumann
> Assignee: Andreas Neumann
> Fix For: 0.10.0-incubating
>
>
> Currently, if an invalid timeout (negative, or too long) is given, the Tx
> manager throws an IllegalArgumentException. The thrift client will catch that
> and apply the retry strategy. However, in this case, retry is pointless, and
> if the strategy is, for example, exponential backoff, if introduces
> unneccessary load and latency.
> The service should instead throw a meaningful exception for that, so that the
> client knows not to retry.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
