Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/37#discussion_r102284134
  
    --- Diff: 
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
    @@ -1124,7 +1110,7 @@ private boolean doTruncateInvalidTxBefore(long time) 
throws InvalidTruncateTimeE
         
         // Find all invalid transactions earlier than truncateWp
         Set<Long> toTruncate = Sets.newHashSet();
    --- End diff --
    
    Actually this can be a `LongSet` so that it can be passed to the 
`doTruncateInvalidTx` and eventually to `invalidTxList.removeAll` as a 
`LongSet` to have more efficient removal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to