Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/42#discussion_r117843422
--- Diff:
tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceClient.java
---
@@ -130,10 +134,11 @@ public static void doMain(boolean verbose,
Configuration conf) throws Exception
* for service discovery. Otherwise it will look for the port in the
* config and use localhost.
* @param config a configuration containing the zookeeper properties
+ * @param clientId id of the client that identifies it when it starts a
transaction
*/
@Inject
- public TransactionServiceClient(Configuration config,
- ThriftClientProvider clientProvider) {
+ public TransactionServiceClient(Configuration config,
ThriftClientProvider clientProvider,
--- End diff --
Some clients like Apache Phoenix do not use the guice modules. They
instantiate `TransactionServiceClient` directly. It will be good to have the
existing constructor too and assign the default value for the clientId in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
