Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/45#discussion_r131594887
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/SecondaryIndexTable.java
 ---
    @@ -177,11 +173,23 @@ public void close() throws IOException {
         } catch (IOException e) {
           try {
             secondaryIndexTable.close();
    +        conn.close();
    --- End diff --
    
    `conn` may not be closed if `secondaryIndexTable.close()` throws an 
exception.
    
    Adding another nested try-catch will make the code complex. Instead what do 
you think about putting each close in its own try-catch block, remember the 
first exception, and add the other exceptions as suppressed to the first 
exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to