[
https://issues.apache.org/jira/browse/TEPHRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159695#comment-16159695
]
ASF GitHub Bot commented on TEPHRA-243:
---------------------------------------
GitHub user anew opened a pull request:
https://github.com/apache/incubator-tephra/pull/53
(TEPHRA-243) Improve logging for slow log append
- adds more detail to the log message (number of entries, bytes written)
- ensures only one thread logs the message concurrently, by moving it into
the method actually writes to storage. Previously all threads logged it even if
they did not write themselves
- changed ThriftTransactionSystemTest to use LocalTransactionLog (otherwise
it does not get tested at all)
- fixed a few unrelated compiler warning encountered on the way
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anew/incubator-tephra tephra-243
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tephra/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 60085beef1c5b8cef90b1b14751ae7aa78b6d909
Author: anew <[email protected]>
Date: 2017-09-09T03:04:38Z
(TEPHRA-243) Improve logging for slow log append
----
> When transaction log sync is slow, the warning message should contain more
> information
> --------------------------------------------------------------------------------------
>
> Key: TEPHRA-243
> URL: https://issues.apache.org/jira/browse/TEPHRA-243
> Project: Tephra
> Issue Type: Improvement
> Affects Versions: 0.12.0-incubating
> Reporter: Andreas Neumann
> Assignee: Andreas Neumann
> Fix For: 0.13.0-incubating
>
>
> Currently we get this message:
> {noformat}
> 2017-08-12 00:59:46,938 - INFO
> [TTransactionServer-rpc-857:o.a.t.p.AbstractTransactionLog@102] - Slow append
> to log txlog.1502517541689, took 1431 msec.
> {noformat}
> It would be more useful to know how many bytes were written, how many edits
> were in this sync.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
