Github user anew commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/55#discussion_r137980868
  
    --- Diff: 
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
 ---
    @@ -335,6 +351,25 @@ private long computePruneUpperBound(TimeRegions 
timeRegions) throws IOException
         return -1;
       }
     
    +  private SortedSet<byte[]> filterDeletedRegions(final Set<TableName> 
existingTables,
    --- End diff --
    
    Better name this filterDeletedTables(), or filterDeletedTableRegions()
    - it does not filter out deleted regions
    - it does filter out all regions of deleted tables 


---

Reply via email to