[
https://issues.apache.org/jira/browse/TEPHRA-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160717#comment-16160717
]
ASF GitHub Bot commented on TEPHRA-244:
---------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/55#discussion_r137980868
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/HBaseTransactionPruningPlugin.java
---
@@ -335,6 +351,25 @@ private long computePruneUpperBound(TimeRegions
timeRegions) throws IOException
return -1;
}
+ private SortedSet<byte[]> filterDeletedRegions(final Set<TableName>
existingTables,
--- End diff --
Better name this filterDeletedTables(), or filterDeletedTableRegions()
- it does not filter out deleted regions
- it does filter out all regions of deleted tables
> Invalid tx pruning does not handle deletion of tables well
> ----------------------------------------------------------
>
> Key: TEPHRA-244
> URL: https://issues.apache.org/jira/browse/TEPHRA-244
> Project: Tephra
> Issue Type: Bug
> Components: core, manager
> Affects Versions: 0.12.0-incubating
> Reporter: Andreas Neumann
> Assignee: Poorna Chandra
> Fix For: 0.13.0-incubating
>
>
> Suppose an application regularly creates and deletes tables (for example,
> temporary tables). In such a scenario, there will always be such a temporary
> table when pruning runs, and its regions will be recorded for that time.
> However, the region will be deleted before it ever compacts or flushes, and
> it will never record prune information. Because all prune times have such
> regions, there will never be a set of transactional regions that all have
> prune info, and pruning will never happen.
> The fix is to exclude deleted tables from the list of regions at each time.
> This is all regions of deleted tables (tables that do not exist any more),
> not deleted regions: a region may disappear due to a split and its data will
> be in new regions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
