Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/47#discussion_r138477861
--- Diff:
tephra-core/src/main/java/org/apache/tephra/TransactionManager.java ---
@@ -206,12 +210,19 @@ public TransactionManager(Configuration conf,
@Nonnull TransactionStateStorage p
// TODO: REMOVE WITH txnBackwardsCompatCheck()
longTimeoutTolerance = conf.getLong("data.tx.long.timeout.tolerance",
10000);
- //
+ ClientIdRetention retention = ClientIdRetention.valueOf(
--- End diff --
It would be good to catch the exception during enum conversion and use the
default value. This way transaction manager will still startup on a
misconfiguration.
---
