[
https://issues.apache.org/jira/browse/TEPHRA-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174415#comment-16174415
]
ASF GitHub Bot commented on TEPHRA-245:
---------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/62#discussion_r140172193
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/txprune/InvalidListPruningDebugTool.java
---
@@ -165,10 +165,10 @@ public void destroy() throws IOException {
*/
@Override
@SuppressWarnings("WeakerAccess")
- public SortedSet<RegionPruneInfoPretty> getIdleRegions(Integer
numRegions, String time) throws IOException {
+ public List<RegionPruneInfoPretty> getIdleRegions(Integer numRegions,
String time) throws IOException {
--- End diff --
so now the result won't be sorted?
Another option is to keep the sorted set, but make the region name part of
the comparable. So that if two have the same prune bound, they still have
different sort keys but end up adjacent to each other in the result. That would
be a sorted result.
> Improve the prune debug tool
> ----------------------------
>
> Key: TEPHRA-245
> URL: https://issues.apache.org/jira/browse/TEPHRA-245
> Project: Tephra
> Issue Type: Improvement
> Components: core, manager
> Affects Versions: 0.12.0-incubating
> Reporter: Andreas Neumann
> Assignee: Poorna Chandra
> Fix For: 0.14.0-incubating
>
>
> The current tool is not very intuitive and it requires deep understanding of
> how pruning works to use it, It would be better if the tool could provide
> instructions: what is needed to make pruning proceed?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
