[
https://issues.apache.org/jira/browse/TEPHRA-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175759#comment-16175759
]
ASF GitHub Bot commented on TEPHRA-263:
---------------------------------------
GitHub user anwar6953 opened a pull request:
https://github.com/apache/incubator-tephra/pull/66
Revert "TEPHRA-263 Enforce TTL, regardless of any in-progress transac…
…tions. Also Handle the case where TTL is longer than the duration from
beginning of epoch to now."
This reverts commit a346efe7560cc3b96349263669c4e15951ad401b.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anwar6953/incubator-tephra
bugfix_release/revert-TEPHRA-263
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tephra/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit e0572c496cbdb2f0296519338b94ce07dbd27f5b
Author: Ali Anwar <[email protected]>
Date: 2017-09-22T00:55:01Z
Revert "TEPHRA-263 Enforce TTL, regardless of any in-progress transactions.
Also Handle the case where TTL is longer than the duration from beginning of
epoch to now."
This reverts commit a346efe7560cc3b96349263669c4e15951ad401b.
----
> TTL is not strictly enforced, if there are long transactions running
> --------------------------------------------------------------------
>
> Key: TEPHRA-263
> URL: https://issues.apache.org/jira/browse/TEPHRA-263
> Project: Tephra
> Issue Type: Bug
> Reporter: Ali Anwar
> Assignee: Ali Anwar
> Fix For: 0.14.0-incubating
>
>
> The logic for filtering for TTL:
> https://github.com/apache/incubator-tephra/blob/release/0.12.0-incubating/tephra-core/src/main/java/org/apache/tephra/util/TxUtils.java#L66
> It is subtracting the TTL duration from the visibility upper bound, but it
> should be subtracting from the current time or the current write pointer
> instead. Otherwise, if the TTL is 1 hour, but the visibility upper bound is
> 22 hours ago (due to some MR that has been in progress for 22 hours), then
> the TTL that is actually enforced will be 23 hours and older data will be
> filtered.
> After the long transactions are invalidated, the TTL is then strictly
> enforced.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
