[ 
https://issues.apache.org/jira/browse/TEPHRA-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368014#comment-16368014
 ] 

ASF GitHub Bot commented on TEPHRA-272:
---------------------------------------

Github user poornachandra commented on a diff in the pull request:

    https://github.com/apache/incubator-tephra/pull/67#discussion_r168878262
  
    --- Diff: 
tephra-hbase-compat-2.0/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
 ---
    @@ -0,0 +1,574 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tephra.hbase.coprocessor;
    +
    +import com.google.common.collect.Maps;
    +import com.google.common.collect.Sets;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.Cell;
    +import org.apache.hadoop.hbase.CellUtil;
    +import org.apache.hadoop.hbase.CoprocessorEnvironment;
    +import org.apache.hadoop.hbase.DoNotRetryIOException;
    +import org.apache.hadoop.hbase.HConstants;
    +import org.apache.hadoop.hbase.TableName;
    +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
    +import org.apache.hadoop.hbase.client.Delete;
    +import org.apache.hadoop.hbase.client.Durability;
    +import org.apache.hadoop.hbase.client.Get;
    +import org.apache.hadoop.hbase.client.OperationWithAttributes;
    +import org.apache.hadoop.hbase.client.Put;
    +import org.apache.hadoop.hbase.client.Scan;
    +import org.apache.hadoop.hbase.client.TableDescriptor;
    +import org.apache.hadoop.hbase.coprocessor.ObserverContext;
    +import org.apache.hadoop.hbase.coprocessor.RegionCoprocessor;
    +import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment;
    +import org.apache.hadoop.hbase.coprocessor.RegionObserver;
    +import org.apache.hadoop.hbase.filter.Filter;
    +import org.apache.hadoop.hbase.filter.FilterBase;
    +import org.apache.hadoop.hbase.regionserver.HStore;
    +import org.apache.hadoop.hbase.regionserver.InternalScanner;
    +import org.apache.hadoop.hbase.regionserver.Region;
    +import org.apache.hadoop.hbase.regionserver.ScanOptions;
    +import org.apache.hadoop.hbase.regionserver.ScanType;
    +import org.apache.hadoop.hbase.regionserver.Store;
    +import org.apache.hadoop.hbase.regionserver.StoreFile;
    +import 
org.apache.hadoop.hbase.regionserver.compactions.CompactionLifeCycleTracker;
    +import org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest;
    +import org.apache.hadoop.hbase.util.Bytes;
    +import org.apache.hadoop.hbase.wal.WALEdit;
    +import org.apache.tephra.Transaction;
    +import org.apache.tephra.TransactionCodec;
    +import org.apache.tephra.TxConstants;
    +import org.apache.tephra.coprocessor.CacheSupplier;
    +import org.apache.tephra.coprocessor.TransactionStateCache;
    +import org.apache.tephra.coprocessor.TransactionStateCacheSupplier;
    +import org.apache.tephra.hbase.txprune.CompactionState;
    +import org.apache.tephra.persist.TransactionVisibilityState;
    +import org.apache.tephra.util.TxUtils;
    +
    +import java.io.IOException;
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.NavigableSet;
    +import java.util.Optional;
    +import java.util.Set;
    +import java.util.concurrent.TimeUnit;
    +
    +import javax.annotation.Nullable;
    +
    +/**
    + * {@code org.apache.hadoop.hbase.coprocessor.RegionObserver} coprocessor 
that handles server-side processing
    + * for transactions:
    + * <ul>
    + *   <li>applies filtering to exclude data from invalid and in-progress 
transactions</li>
    + *   <li>overrides the scanner returned for flush and compaction to drop 
data written by invalidated transactions,
    + *   or expired due to TTL.</li>
    + * </ul>
    + *
    + * <p>In order to use this coprocessor for transactions, configure the 
class on any table involved in transactions,
    + * or on all user tables by adding the following to hbase-site.xml:
    + * {@code
    + * <property>
    + *   <name>hbase.coprocessor.region.classes</name>
    + *   
<value>org.apache.tephra.hbase.coprocessor.TransactionProcessor</value>
    + * </property>
    + * }
    + * </p>
    + *
    + * <p>HBase {@code Get} and {@code Scan} operations should have the 
current transaction serialized on to the operation
    + * as an attribute:
    + * {@code
    + * Transaction t = ...;
    + * Get get = new Get(...);
    + * TransactionCodec codec = new TransactionCodec();
    + * codec.addToOperation(get, t);
    + * }
    + * </p>
    + */
    +public class TransactionProcessor implements RegionObserver, 
RegionCoprocessor {
    +  private static final Log LOG = 
LogFactory.getLog(TransactionProcessor.class);
    +
    +  private final TransactionCodec txCodec;
    +  private TransactionStateCache cache;
    +  private volatile CompactionState compactionState;
    +  private CacheSupplier<TransactionStateCache> cacheSupplier;
    +
    +  protected volatile Boolean pruneEnable;
    +  protected volatile Long txMaxLifetimeMillis;
    +  protected Map<byte[], Long> ttlByFamily = 
Maps.newTreeMap(Bytes.BYTES_COMPARATOR);
    +  protected boolean allowEmptyValues = 
TxConstants.ALLOW_EMPTY_VALUES_DEFAULT;
    +  protected boolean readNonTxnData = TxConstants.DEFAULT_READ_NON_TX_DATA;
    +
    +  public TransactionProcessor() {
    +    this.txCodec = new TransactionCodec();
    +  }
    +
    +  @Override
    +  public Optional getRegionObserver() {
    +    return Optional.of(this);
    +  }
    +
    +  /* RegionObserver implementation */
    +
    +  @Override
    +  public void start(CoprocessorEnvironment e) throws IOException {
    +    if (e instanceof RegionCoprocessorEnvironment) {
    +      RegionCoprocessorEnvironment env = (RegionCoprocessorEnvironment) e;
    +      this.cacheSupplier = getTransactionStateCacheSupplier(env);
    +      this.cache = cacheSupplier.get();
    +
    +      TableDescriptor tableDesc = env.getRegion().getTableDescriptor();
    +      for (ColumnFamilyDescriptor columnDesc : 
tableDesc.getColumnFamilies()) {
    +        byte[] columnTTL = 
columnDesc.getValue(Bytes.toBytes(TxConstants.PROPERTY_TTL));
    +        long ttl = 0;
    +        if (columnTTL != null) {
    +          try {
    +            ttl = Long.parseLong(Bytes.toString(columnTTL));
    +            LOG.info("Family " + columnDesc.getNameAsString() + " has TTL 
of " + columnTTL);
    --- End diff --
    
    `columnTTL` is now a byte array, hence it won't get printed properly. It 
would be good to do the  `Bytes.toLong(columnTTL)` conversion at line 142 
itself.


> Add HBase 2.0 compatibility module
> ----------------------------------
>
>                 Key: TEPHRA-272
>                 URL: https://issues.apache.org/jira/browse/TEPHRA-272
>             Project: Tephra
>          Issue Type: Improvement
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Major
>              Labels: HBase-2.0
>             Fix For: 0.14.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to