Having the keys in the dist area and not in Tephra's github is fine. I misunderstood which KEYS file you were referencing. Maybe the one in the Tephra repo should be removed.
I agree that Tephra doesn't need the licenses if it's not shipping the code. Alan. On Tue, Aug 21, 2018 at 11:26 AM James Taylor <jamestay...@apache.org> wrote: > Thanks for checking it out, Alan. I checked in my public key info here[1], > but I'll commit to master branch as well. Based on Josh's email from prior > release vote [2], it looks like the rat check is failing for the following > files: > > <snip> > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/Aopa.PL > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/Asm.BSD > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/JLine.BSD > apache-tephra-0.14.0-incubating/tephra-distribution/licenses/Logback.EPL > apache-tephra-0.14.0-incubating/tephra-distribution/NOTICE_BINARY > </snip> > > Since Tephra does a source-only release, I don't think the NOTICE_BINARY is > necessary. Same with the licenses - not sure we need those either. We're > not including any source code from those projects - those would just be > pulled in through maven when built. > > Thoughts? > James > > [1] https://dist.apache.org/repos/dist/dev/incubator/tephra/KEYS > [2] > > https://lists.apache.org/thread.html/fed5c54f775fda7a2e7393095f8d16a7e439e8c51b7b1be7619fd283@%3Cgeneral.incubator.apache.org%3E > > > On Tue, Aug 21, 2018 at 10:49 AM, Alan Gates <alanfga...@gmail.com> wrote: > > > Which version of the KEYS file did you add it to? I don't see a change > to > > the KEYS file in master or the 0.15.0 branch. > > > > Also, at this point I'm +0 on this release, as the rat check still fails, > > which I complained about on the last release vote. As indicated by the > +0 > > you don't have to fix this to release, but you do to get my vote. :) > > > > Alan. > > > > On Mon, Aug 20, 2018 at 10:49 PM Poorna Chandra <poo...@apache.org> > wrote: > > > > > +1 > > > > > > On Mon, Aug 20, 2018 at 11:45 PM James Taylor <jamestay...@apache.org> > > > wrote: > > > > > > > Thanks for reviewing, Poorna. Yes, my code signing key has changed. > > I've > > > > removed the MD5 file from the source distribution and added my new > code > > > > signing key to the KEYS file. > > > > > > > > James > > > > > > > > On Sat, Aug 18, 2018 at 7:38 PM, Poorna Chandra <poo...@apache.org> > > > wrote: > > > > > > > > > -1 > > > > > > > > > > - Checked build and test > > > > > - Checked signature and checksums > > > > > - Checked LICENSE, NOTICE and DISCLAIMER > > > > > - Checked release tag and hash > > > > > > > > > > A couple of things need to be fixed - > > > > > 1. The code signing key is different than what is in the KEYS file > > and > > > > > people.apache.org/keys (BE0F in the KEYS file vs DC24 used to > sign). > > > Did > > > > > your code signing key change? If so, please add it to the KEYS > file. > > > > > 2. The release distribution policy [1] has been changed to say the > > > > release > > > > > should not supply MD5 checksum file. > > > > > > > > > > Thanks, > > > > > Poorna > > > > > > > > > > [1] - > https://www.apache.org/dev/release-distribution#sigs-and-sums > > > > > > > > > > On Thu, Aug 16, 2018 at 11:00 PM, James Taylor < > > jamestay...@apache.org > > > > > > > > > wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > This is a call for a vote on releasing Apache Tephra > > > 0.15.0-incubating, > > > > > > release candidate 1. This is the eighth release of Tephra. > > > > > > > > > > > > The source tarball, including signatures, digests, etc. can be > > found > > > > at: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0. > > > > > > 15.0-incubating-rc1/src > > > > > > > > > > > > The tag to be voted upon is v0.15.0-incubating: > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra. > > > > > > git;a=shortlog;h=refs/tags/v0.15.0-incubating > > > > > > > > > > > > The release hash is fe4885003dfbc8fcfc2d0ae4192a109b03eaebe5: > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-tephra. > > > > > git;a=commit;h= > > > > > > fe4885003dfbc8fcfc2d0ae4192a109b03eaebe5 > > > > > > > > > > > > The Nexus Staging URL: > > > > > > > > > > https://repository.apache.org/content/repositories/ > > orgapachetephra-1012 > > > > > > > > > > > > Release artifacts are signed with the following key: > > > > > > http://people.apache.org/keys/committer/jamestaylor > > > > > > > > > > > > KEYS file available: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/tephra/KEYS > > > > > > > > > > > > For information about the contents of this release, see: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/tephra/0. > > > > > > 15.0-incubating-rc1/CHANGES.txt > > > > > > > > > > > > Please vote on releasing this package as Apache Tephra > > > > 0.15.0-incubating > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > > > [ ] +1 Release this package as Apache Tephra 0.15.0-incubating > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > > > Thanks, > > > > > > James > > > > > > > > > > > > > > > > > > > > >
