aglinxinyuan commented on code in PR #3622:
URL: https://github.com/apache/texera/pull/3622#discussion_r2264160388


##########
core/config/src/main/resources/default.conf:
##########
@@ -50,3 +50,18 @@ gui {
     about_enabled = true
   }
 }
+
+dataset {
+  # the file size limit for dataset upload
+  single-file-upload-maximum-size-mb = 20

Review Comment:
   Use the same style as the other vars in this file. i.e. change to 
`single_file_upload_max_size_mb`



##########
core/config/src/main/resources/default.conf:
##########
@@ -50,3 +50,18 @@ gui {
     about_enabled = true
   }
 }
+
+dataset {
+  # the file size limit for dataset upload
+  single-file-upload-maximum-size-mb = 20
+  single-file-upload-maximum-size-mb = 
${?GUI_DATASET_SINGLE_FILE_UPLOAD_MAXIMUM_SIZE_MB}

Review Comment:
   We don't need this env var anymore since it's configable on gui.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to