Copilot commented on code in PR #3651:
URL: https://github.com/apache/texera/pull/3651#discussion_r2267421798
##########
core/gui/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html:
##########
@@ -66,17 +66,24 @@ <h1>Workflow Detail Page</h1>
<span>{{ formatCount(likeCount) }}</span>
</button>
+ <button
+ nz-button
+ class="clone-button"
+ title="Copy">
+ <i
+ nz-icon
+ nzType="user"></i>
Review Comment:
[nitpick] The user icon may not be semantically appropriate for representing
clone count. Consider using an icon that better represents cloning or copying,
such as 'copy' or 'fork'.
```suggestion
nzType="copy"></i>
```
##########
core/gui/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html:
##########
@@ -66,17 +66,24 @@ <h1>Workflow Detail Page</h1>
<span>{{ formatCount(likeCount) }}</span>
</button>
+ <button
+ nz-button
+ class="clone-button"
+ title="Copy">
+ <i
+ nz-icon
+ nzType="user"></i>
+ <span>{{ formatCount(cloneCount) }}</span>
+ </button>
+
<button
nz-button
nzType="primary"
class="clone-button"
title="Copy"
Review Comment:
The title attribute should be "Clone" to match the button text and actual
functionality, rather than "Copy".
```suggestion
title="Clone"
```
##########
core/gui/src/app/hub/component/workflow/detail/hub-workflow-detail.component.html:
##########
@@ -66,17 +66,24 @@ <h1>Workflow Detail Page</h1>
<span>{{ formatCount(likeCount) }}</span>
</button>
+ <button
+ nz-button
+ class="clone-button"
+ title="Copy">
Review Comment:
The title attribute should be "Clone count" or similar to accurately
describe what this button displays, rather than "Copy" which suggests an action.
```suggestion
title="Clone count">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
