Xiao-zhen-Liu opened a new pull request, #3655: URL: https://github.com/apache/texera/pull/3655
For the cost-based scheduler in Amber, ideally, the ResourceAllocator should be part of the CostEstimator. However for historical reasons and the fact that the current ResourceAllocator is not cost-based at all, we have been separating these two modules. To make the modules clearer and to make it easier for future updates to the ResourceAllocator, this PR merges the ResourceAllocator as part of CostEstimator. Note as the ResourceAllocator does not produce a real cost currently, the CostEstimator still uses a cost model that does not rely on the cost estimator. In the future when the ResourceAllocator does produce a real cost, we can further consolidate these two modules. ### Code Changes - `ResourceAllocator` is now inside `CostEstimator` for `CostBasedScheduleGenerator` - `allocateResources()` is now executed as part of the search process for `CostBasedScheduleGenerator` (previously it was done after the search), and is merged with `estimate()` to be `allocateResourcesAndEvaluateCost` - Moved some methods only used by `ExpansionGreedyScheduleGenerator` from the base class into that class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
