xuang7 commented on code in PR #3664:
URL: https://github.com/apache/texera/pull/3664#discussion_r2281098642
##########
core/gui/src/app/dashboard/component/admin/settings/admin-settings.component.ts:
##########
@@ -204,8 +210,28 @@ export class AdminSettingsComponent implements OnInit {
}
saveDatasetSettings(): void {
- if (this.maxFileSizeMB < 1 || this.maxConcurrentChunks < 1 ||
this.chunkSizeMB < 1) {
- this.message.info("Value must be at least 1.");
+ if (this.maxFileSizeMB < 1 || this.maxFileSizeMB > this.MAX_FILE_SIZE_MB) {
Review Comment:
Fixed! Left one check in the ts file to prevent non-numeric values. Is that
okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
