aicam commented on PR #3671: URL: https://github.com/apache/texera/pull/3671#issuecomment-3197081241
> Here are more comments about this PR: > > * The issue [Adding User's Activeness on Admin Dashboard #3624](https://github.com/apache/texera/issues/3624) was already closed before this PR. Why does it say "Closes [Adding User's Activeness on Admin Dashboard #3624](https://github.com/apache/texera/issues/3624)"? > * The name of the new table "time_log" is not clear enough. I suggest we change it to "user_last_login_time" or something like that. > * Since this PR changes the DDL, we need to notify the team after it's merged. @chenlica the PR was in continuous of previous [PR](https://github.com/apache/texera/pull/3625), we have two ddl files, one is in `scripts/sql` and other one in `deployment/k8s/texera-helmchart/files`, @jaeyun0503 already added the needed table in `sql` directory which is used for local development, however, the one for Kubernetes was not updated, we might need to sync these two files but currently they should be synced manually. Jae has already added `10.sql` in `update` folder and notified people to run it, this change is only to update k8s database file. For changing the table name, @jaeyun0503 can raise a new PR to completely change it through the code since this PR was basically a fix for the previous one and does not include all implementation of `time_log`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
