Xiao-zhen-Liu commented on code in PR #3660:
URL: https://github.com/apache/texera/pull/3660#discussion_r2302317877
##########
core/amber/src/main/scala/edu/uci/ics/amber/engine/architecture/scheduling/CostBasedScheduleGenerator.scala:
##########
@@ -75,6 +76,17 @@ class CostBasedScheduleGenerator(
actorId = actorId
)
+ private case class CostEstimatorMemoKey(
+ physicalOpIds: Set[PhysicalOpIdentity],
+ physicalLinkIds: Set[PhysicalLink],
+ portIds: Set[GlobalPortIdentity],
+ resourceConfig: Option[ResourceConfig]
Review Comment:
No, the current resource allocator needs to check the existing
ResourceConfig of the region so this needs to be provided.
##########
core/amber/src/main/scala/edu/uci/ics/amber/engine/architecture/scheduling/CostBasedScheduleGenerator.scala:
##########
@@ -75,6 +76,17 @@ class CostBasedScheduleGenerator(
actorId = actorId
)
+ private case class CostEstimatorMemoKey(
+ physicalOpIds: Set[PhysicalOpIdentity],
+ physicalLinkIds: Set[PhysicalLink],
+ portIds: Set[GlobalPortIdentity],
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
