Copilot commented on code in PR #3722:
URL: https://github.com/apache/texera/pull/3722#discussion_r2335053328
##########
core/gui/src/app/workspace/component/menu/menu.component.scss:
##########
@@ -153,20 +153,13 @@ i {
#expanded-utilities {
display: inline-block;
- @media screen and (max-width: 1024px) {
- display: none;
- }
-}
-
-#expanded-utilities {
- display: inline-block;
- @media screen and (max-width: 960px) {
+ @media screen and (max-width: 1250px) {
display: none;
}
}
#utilities-dropdown-button {
- @media screen and (min-width: 961px) {
+ @media screen and (min-width: 1251px) {
display: none;
}
}
Review Comment:
[nitpick] Consider using CSS custom properties (variables) for the
breakpoint values. This would make the code more maintainable by defining the
breakpoint once (e.g., `--utilities-breakpoint: 1250px`) and referencing it in
both media queries to ensure consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
