Copilot commented on code in PR #3729:
URL: https://github.com/apache/texera/pull/3729#discussion_r2342454284
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/EmailTemplate.scala:
##########
@@ -54,7 +50,7 @@ object EmailTemplate {
if (toAdmin) {
val subject =
if (deployment.nonEmpty)
- s"New Account Request to $deployment Pending Approval"
+ s"New Account Request Pending Approval for [$deployment]"
Review Comment:
[nitpick] The square bracket formatting `[$deployment]` is inconsistent with
the original format that used `to $deployment` and `on $deployment`. Consider
using a consistent preposition format or document why square brackets are
preferred for these email subjects.
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/EmailTemplate.scala:
##########
@@ -73,7 +69,11 @@ object EmailTemplate {
|""".stripMargin
EmailMessage(subject = subject, content = content, receiver =
receiverEmail)
} else {
- val subject = "Account Request Received"
+ val subject =
+ if (deployment.nonEmpty)
+ s"Account Request Received for [$deployment]"
Review Comment:
[nitpick] The square bracket formatting `[$deployment]` is inconsistent with
the original format that used `to $deployment` and `on $deployment`. Consider
using a consistent preposition format or document why square brackets are
preferred for these email subjects.
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/EmailTemplate.scala:
##########
@@ -99,7 +99,7 @@ object EmailTemplate {
def createRoleChangeTemplate(receiverEmail: String, newRole: UserRoleEnum):
EmailMessage = {
val subject =
if (deployment.nonEmpty)
- s"Your Role Has Been Updated on $deployment"
+ s"Your Role Has Been Updated for [$deployment]"
Review Comment:
[nitpick] The square bracket formatting `[$deployment]` is inconsistent with
the original format that used `to $deployment` and `on $deployment`. Consider
using a consistent preposition format or document why square brackets are
preferred for these email subjects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
