bobbai00 commented on code in PR #3729:
URL: https://github.com/apache/texera/pull/3729#discussion_r2345456864
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/EmailTemplate.scala:
##########
@@ -53,11 +49,8 @@ object EmailTemplate {
): EmailMessage = {
if (toAdmin) {
val subject =
- if (deployment.nonEmpty)
- s"New Account Request to $deployment Pending Approval"
- else
- "New Account Request Pending Approval"
-
+ s"New Account Request Pending Approval${if (deployment.nonEmpty) s"
for [$deployment]"
Review Comment:
I agree with @seongjinyoon . Since this literal should only be used here,
there is no need to extract it out as a constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
