madisonmlin commented on PR #3728:
URL: https://github.com/apache/texera/pull/3728#issuecomment-3358042533

   > Please explain why you needed two separate request, from my understanding, 
if the request would be only form based, then export to dataset can get the 
token from parameter so basically `form` request is compatible with export to 
`dataset`.
   
   When we export to `dataset`, we want to return the HTTP response of the 
export so that the frontend can verify the success/failure of the export and 
display notifications accordingly. Using forms, the browser will handle the 
request and response, so the frontend will not have access to it. If we want to 
return the HTTP response, we'll have to intercept the form submission and use 
the frontend to send the form data to the backend itself instead of allowing 
the browser to do this automatically. Then, our frontend will be able to 
receive the HTTP response. This feels a bit unnecessary when we can just use a 
regular HTTP request, so requests to `dataset` and `local` have separate 
methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to