kunwp1 commented on code in PR #3772:
URL: https://github.com/apache/texera/pull/3772#discussion_r2396055584
##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/FileResolver.scala:
##########
Review Comment:
For the implementation of `parseDatasetPath`, please re-use the logic from
`datasetResolveFunc`. It also has a code to extract ownerEmail and datasetName.
Please take care of the duplicate codes while doing it.
##########
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/user/workflow/WorkflowExecutionsResource.scala:
##########
@@ -696,12 +827,41 @@ class WorkflowExecutionsResource {
): Response = {
if (request.operators.size <= 0)
- Response
+ return Response
Review Comment:
Please revert this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
