Ma77Ball commented on code in PR #3809:
URL: https://github.com/apache/texera/pull/3809#discussion_r2400467956
##########
core/gui/src/app/workspace/component/workflow-editor/workflow-editor.component.ts:
##########
@@ -1422,13 +1421,23 @@ export class WorkflowEditorComponent implements OnInit,
AfterViewInit, OnDestroy
private static RemoveButton: new () => joint.linkTools.Button;
private static getRemoveButton(): new () => joint.linkTools.Button {
- // Check if the class has already been created.
if (!WorkflowEditorComponent.RemoveButton) {
- // If not, create it once and store it in the static property.
WorkflowEditorComponent.RemoveButton = joint.linkTools.Button.extend({
name: "remove-button",
options: {
markup: [
+ {
+ tagName: "circle",
+ selector: "hit-area",
+ attributes: {
+ r: 10,
+ fill: "#000",
+ "fill-opacity": 0.001,
+ stroke: "none",
+ "pointer-events": "visibleFill",
+ cursor: "pointer",
+ },
+ },
Review Comment:
The original object in the PR cannot be filled (or changed to accomplish
this effect), as this would change the appearance of the delete button, which
we want to standardize. The object is broken down into three parts: the red
outer circle, the red X, and the transparent hit box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
