Copilot commented on code in PR #3882:
URL: https://github.com/apache/texera/pull/3882#discussion_r2424997996


##########
Dockerfile:
##########
@@ -49,9 +49,9 @@ WORKDIR /core
 COPY .git ../.git
 COPY --from=nodegui /gui/dist ./gui/dist
 
-RUN scripts/build-services.sh
+RUN ../bin/build-services.sh

Review Comment:
   The script path `../bin/build-services.sh` may be incorrect. Since the 
working directory is `/core`, the relative path `../bin/` would point to 
`/bin/build-services.sh` which is likely not the intended location for project 
scripts.
   ```suggestion
   RUN bin/build-services.sh
   ```



##########
Dockerfile:
##########
@@ -49,9 +49,9 @@ WORKDIR /core
 COPY .git ../.git
 COPY --from=nodegui /gui/dist ./gui/dist
 
-RUN scripts/build-services.sh
+RUN ../bin/build-services.sh
 
-CMD ["scripts/deploy-docker.sh"]
+CMD ["../bin/deploy-docker.sh"]

Review Comment:
   The script path `../bin/deploy-docker.sh` may be incorrect. Since the 
working directory is `/core`, the relative path `../bin/` would point to 
`/bin/deploy-docker.sh` which is likely not the intended location for project 
scripts.
   ```suggestion
   CMD ["bin/deploy-docker.sh"]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to